Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Update Terraform provider to support "dir" in "coder_agent"#1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 3 commits intomainfromupdatetf
May 2, 2022

Conversation

kylecarbs
Copy link
Member

This allows users to specify a starting directory for shell sessions.

@kylecarbskylecarbs self-assigned thisApr 29, 2022
@codecov
Copy link

codecovbot commentedApr 29, 2022•
edited
Loading

Codecov Report

Merging#1219 (0e7988e) intomain (b948f2d) willincrease coverage by0.02%.
The diff coverage is80.00%.

@@            Coverage Diff             @@##             main    #1219      +/-   ##==========================================+ Coverage   65.87%   65.90%   +0.02%==========================================  Files         272      272                Lines       17886    17917      +31       Branches      192      192              ==========================================+ Hits        11783    11808      +25- Misses       4877     4881       +4- Partials     1226     1228       +2
FlagCoverage Δ
unittest-go-macos-latest53.19% <40.00%> (-0.16%)⬇️
unittest-go-postgres-64.85% <80.00%> (+0.04%)⬆️
unittest-go-ubuntu-latest55.61% <56.00%> (+<0.01%)⬆️
unittest-go-windows-202251.55% <40.00%> (-1.26%)⬇️
unittest-js69.96% <ø> (ø)
Impacted FilesCoverage Δ
codersdk/workspaceresources.go45.45% <ø> (ø)
provisioner/terraform/provision.go70.46% <44.44%> (-0.94%)⬇️
agent/agent.go65.36% <100.00%> (-0.27%)⬇️
coderd/database/queries.sql.go81.14% <100.00%> (+0.07%)⬆️
coderd/provisionerdaemons.go63.48% <100.00%> (+0.18%)⬆️
coderd/workspaceagents.go58.83% <100.00%> (+2.06%)⬆️
pty/start_other.go64.70% <0.00%> (-23.53%)⬇️
pty/pty_windows.go70.14% <0.00%> (-4.48%)⬇️
peer/channel.go84.39% <0.00%> (-2.32%)⬇️
... and7 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb948f2d...0e7988e. Read thecomment docs.

This allows users to specify a starting directory for shell sessions.
Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✔️ FE is just generated types, LGTM!

kylecarbs reacted with thumbs up emoji
Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we need to addDirectory toInsertWorkspaceAgentParams? Or doesDirectory get set on the row somewhere else?

@kylecarbs
Copy link
MemberAuthor

@code-asher good catch!

@kylecarbs
Copy link
MemberAuthor

@code-asher I'm going to add a test to ensure the directory gets set.

@kylecarbs
Copy link
MemberAuthor

@code-asher fixed!

@kylecarbskylecarbs merged commit8701e00 intomainMay 2, 2022
@kylecarbskylecarbs deleted the updatetf branchMay 2, 2022 15:27
kylecarbs added a commit that referenced this pull requestJun 10, 2022
)This allows users to specify a starting directory for shell sessions.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled left review comments

@code-ashercode-ashercode-asher left review comments

@coadlercoadlercoadler approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@kylecarbs@coadler@greyscaled@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp