Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: improve clipboard support on HTTP connections and older browsers#12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 2 commits intomainfrommes/clipboard-http-fix
Feb 15, 2024

Conversation

Parkreiner
Copy link
Member

@ParkreinerParkreiner commentedFeb 15, 2024•
edited
Loading

Closes#12171

Changes made

  • Makes sure that on older browsers and HTTP-only deployments, trying to copy to a clipboard succeeds

Other notes

  • Will be making some new tests around all our clipboard functionality shortly. Just wanted to get this out as a hotfix
  • The method that makes this workaround possible relies is officially deprecated.As mentioned here, there is a real possibility down the line that we will not be able to support HTTP-only users going forward without even more workarounds that go beyond polyfilling clipboard logic

@ParkreinerParkreiner self-assigned thisFeb 15, 2024
Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ParkreinerParkreiner changed the titlefix: add future-proofing for clipboard copies on http connectionsfix: let users copy clipboard values on HTTP connections and older browsersFeb 15, 2024
@ParkreinerParkreiner changed the titlefix: let users copy clipboard values on HTTP connections and older browsersfix: resolve edge case for copying to clipboard when using HTTP connections and older browsersFeb 15, 2024
@ParkreinerParkreiner changed the titlefix: resolve edge case for copying to clipboard when using HTTP connections and older browsersfix: improve clipboard support on HTTP connections and older browsersFeb 15, 2024
@ParkreinerParkreiner merged commitfbd436c intomainFeb 15, 2024
@ParkreinerParkreiner deleted the mes/clipboard-http-fix branchFebruary 15, 2024 21:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

Assignees

@ParkreinerParkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to copy session token from the cli-auth page
1 participant
@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp