Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: move LogSender to agentsdk#12158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/10534-log-sender-agentsdk
Feb 20, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedFeb 15, 2024•
edited
Loading

Moves the LogSender to agentsdk and deprecates LogsSender based on the v1 API.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedFeb 15, 2024•
edited
Loading

@spikecurtisspikecurtis marked this pull request as ready for reviewFebruary 15, 2024 12:51
Base automatically changed fromspike/10534-log-sender tomainFebruary 15, 2024 12:57
pl, err := ProtoFromLog(log)
if err != nil {
logger.Critical(context.Background(), "failed to convert log", slog.Error(err))
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Echo from review of previous PR:

Suggested change
return
continue

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I changed this to drop**Coder Internal Error**: Failed to convert log into the logs stream, so it's super obvious there is a big problem.

mafredri reacted with heart emoji
@spikecurtisspikecurtisforce-pushed thespike/10534-log-sender-agentsdk branch from2a2203e to900e32aCompareFebruary 16, 2024 10:12
@spikecurtisspikecurtis merged commit081e37d intomainFeb 20, 2024
@spikecurtisspikecurtis deleted the spike/10534-log-sender-agentsdk branchFebruary 20, 2024 06:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp