Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: change servertailnet to register the DERP dialer before setting DERP map#12137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/derp-dial-before-map
Feb 15, 2024

Conversation

spikecurtis
Copy link
Contributor

I noticed a possible race where tailnet.Conn can try to dial the embedded region before we've set our custom dialer that send the DERP in-memory. This closes that race and adds a test case for servertailnet with no STUN and an embedded relay

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedFeb 14, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedFeb 14, 2024•
edited
Loading

✔️ PR 12137 Created successfully.
🚀 Access the credentialshere.

cc:@mtojek

github-actions[bot] reacted with rocket emoji

@spikecurtisspikecurtis merged commit2d0b910 intomainFeb 15, 2024
@spikecurtisspikecurtis deleted the spike/derp-dial-before-map branchFebruary 15, 2024 06:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@mafredri@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp