NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: ensure rtc state changes can't log after close#1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 1 commit intomainfromcolin/fix-conn-log-close

Apr 28, 2022

Merged

fix: ensure rtc state changes can't log after close#1213

coadler merged 1 commit intomainfromcolin/fix-conn-log-close

Apr 28, 2022

Conversation

Copy link

Contributor

coadler commentedApr 28, 2022

No description provided.

fix: ensure rtc state changes can't log after close

3140a58

coadler self-assigned this

Apr 28, 2022

coadler requested a review fromkylecarbs

April 28, 2022 18:14

Copy link

codecovbot commentedApr 28, 2022•
edited
Loading

Codecov Report

Merging#1213 (3140a58) intomain (e330dc1) willdecrease coverage by0.01%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main    #1213      +/-   ##==========================================- Coverage   65.43%   65.41%   -0.02%==========================================  Files         265      265                Lines       16937    16946       +9       Branches      157      157              ==========================================+ Hits        11083    11086       +3- Misses       4694     4700       +6  Partials     1160     1160

Flag	Coverage Δ
unittest-go-macos-latest	`52.98% <0.00%> (+0.08%)`	⬆️
unittest-go-postgres-	`64.53% <0.00%> (-0.14%)`	⬇️
unittest-go-ubuntu-latest	`55.31% <0.00%> (-0.10%)`	⬇️
unittest-go-windows-2022	`52.46% <0.00%> (-0.04%)`	⬇️
unittest-js	`66.50% <ø> (ø)`

Impacted Files	Coverage Δ
peer/conn.go	`78.41% <0.00%> (-3.32%)`	⬇️
peerbroker/listen.go	`82.35% <0.00%> (-5.05%)`	⬇️
agent/agent.go	`66.31% <0.00%> (-0.71%)`	⬇️
coderd/provisionerdaemons.go	`62.79% <0.00%> (-0.51%)`	⬇️
provisionerd/provisionerd.go	`76.30% <0.00%> (-0.41%)`	⬇️
provisioner/terraform/provision.go	`71.39% <0.00%> (+0.43%)`	⬆️
coderd/workspaceagents.go	`58.14% <0.00%> (+1.27%)`	⬆️
peer/channel.go	`84.97% <0.00%> (+1.73%)`	⬆️
provisioner/echo/serve.go	`59.20% <0.00%> (+4.80%)`	⬆️
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee330dc1...3140a58. Read thecomment docs.