NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix: Restore static credentials for develop.sh#1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 1 commit intomainfrommafredri/restore-develop-sh-password-behavior

Apr 28, 2022

Merged

fix: Restore static credentials for develop.sh#1212

mafredri merged 1 commit intomainfrommafredri/restore-develop-sh-password-behavior

Apr 28, 2022

Conversation

Copy link

Member

mafredri commentedApr 28, 2022•
edited
Loading

This PR restores static credentials forcoder server --dev when run viadevelop.sh.

fix: Restore static credentials for develop.sh

3d74b91

mafredri self-assigned this

Apr 28, 2022

mafredri requested a review frompresleyp

April 28, 2022 17:24

presleyp approved these changes

Apr 28, 2022

View reviewed changes

Copy link

Contributor

presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Copy link

Contributor

presleyp commentedApr 28, 2022

@BrunoQuaresma @vapurrmaid @code-asher speak up if you disagree with this approach! Just thought it would be simpler than making sure we've exported, or copy pasting new passwords on each run.

Copy link

codecovbot commentedApr 28, 2022•
edited
Loading

Codecov Report

Merging#1212 (3d74b91) intomain (e330dc1) willincrease coverage by0.53%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1212      +/-   ##==========================================+ Coverage   64.83%   65.36%   +0.53%==========================================  Files         259      265       +6       Lines       16716    16937     +221       Branches      157      157              ==========================================+ Hits        10837    11071     +234+ Misses       4707     4704       -3+ Partials     1172     1162      -10

Flag	Coverage Δ
unittest-go-macos-latest	`52.90% <ø> (?)`
unittest-go-postgres-	`64.60% <ø> (-0.08%)`	⬇️
unittest-go-ubuntu-latest	`55.32% <ø> (?)`
unittest-go-windows-2022	`52.48% <ø> (?)`
unittest-js	`66.50% <ø> (ø)`

Impacted Files	Coverage Δ
provisionersdk/serve.go	`35.13% <0.00%> (-8.11%)`	⬇️
coderd/workspaceagents.go	`55.59% <0.00%> (-1.28%)`	⬇️
coderd/provisionerdaemons.go	`62.28% <0.00%> (-1.02%)`	⬇️
cli/ssh_windows.go	`0.00% <0.00%> (ø)`
pty/start_windows.go	`66.95% <0.00%> (ø)`
cli/cliui/cliui_darwin.go	`0.00% <0.00%> (ø)`
pty/pty_windows.go	`70.14% <0.00%> (ø)`
agent/usershell/usershell_darwin.go	`100.00% <0.00%> (ø)`
agent/usershell/usershell_windows.go	`83.33% <0.00%> (ø)`
coderd/users.go	`61.27% <0.00%> (+0.51%)`	⬆️
... and15 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee330dc1...3d74b91. Read thecomment docs.