- Notifications
You must be signed in to change notification settings - Fork928
ci: use repo secret for syncing winget-pkgs fork#12108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedFeb 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
cdrcommunity added a commit to coder/cla that referenced this pull requestFeb 12, 2024
matifali approved these changesFeb 13, 2024
Thank you Danish. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I believe we need to use a real token to sync winget-pkgs fork. Using
github.tokenhasn't worked for the past few release runs. This is in hopes to unblock the publish failure occurring for some releases now.Example:https://github.com/coder/coder/actions/runs/7867766212/job/21464043959
A reference implementation where the sync fork step is working correctly also uses the secret variable (implying a real token):https://github.com/microsoft/devhome/blob/7e962067f567de8044ab5a8a7f996d8a435d4392/.github/workflows/winget-submission.yml#L13-L15