Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(examples): remove deprecated startup_script_timeout#12104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 3 commits intomainfromcj/rm-startup-script-timeout
Feb 12, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedFeb 12, 2024•
edited
Loading

Creating a template from examples results in deprecation warnings, which is a bit of a product smell from a user's perspective.

@johnstcnjohnstcn self-assigned thisFeb 12, 2024
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is the alternative of this deprecated timeout flags?

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
@johnstcn
Copy link
MemberAuthor

johnstcn commentedFeb 12, 2024•
edited
Loading

What is the alternative of this deprecated timeout flags?

@mafredri feel free to correct me if I'm wrong, but I believestartup_script_behavior is the replacement:https://registry.terraform.io/providers/coder/coder/latest/docs/resources/agent#startup_script_behavior

edit: see below

matifali reacted with thumbs up emoji

@mafredri
Copy link
Member

What is the alternative of this deprecated timeout flags?

@mafredri feel free to correct me if I'm wrong, but I believestartup_script_behavior is the replacement:registry.terraform.io/providers/coder/coder/latest/docs/resources/agent#startup_script_behavior

There is no replacement, actually. Andstartup_script_behavior is kind of deprecated too (as per updated provider docs), bothstartup_script andstartup_script_behavior are simply aliases for defining acoder_script with certain properties.

johnstcn reacted with thumbs up emoji

@matifali
Copy link
Member

matifali commentedFeb 12, 2024•
edited
Loading

It is a bit out of scope, but thoughts on replacing allarch andos attributes for thecoder_agent resource withdata.coder_workspace.me.arch anddata.coder_workspace.me.os. Currently, I see a mix of both. We can do it in a separate PR, but we want your thoughts.

One downside of using it could be a failed workspace when workspace compute andprovisionerd have differentos orarch.

@johnstcn
Copy link
MemberAuthor

A bit out of scope but thoughts on replacing allarch andos attributes for thecoder_agent resource withdarta.coder_workspace.me.arch anddata.coder_workspace.me.os. Currently, I see a mix of both. We can do it in a separate PR, but we would like to hear your thoughts.

One downside of using it could be when workspace compute andprovisionerd have different os orarch.

Definitely something for a separate PR, but I think the case you mention is solvable with a comment above the setting.

mafredri reacted with thumbs up emoji

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@matifali
Copy link
Member

What is the alternative of this deprecated timeout flags?

@mafredri feel free to correct me if I'm wrong, but I believestartup_script_behavior is the replacement:registry.terraform.io/providers/coder/coder/latest/docs/resources/agent#startup_script_behavior

There is no replacement, actually. Andstartup_script_behavior is kind of deprecated too (as per updated provider docs), bothstartup_script andstartup_script_behavior are simply aliases for defining acoder_script with certain properties.

We should then also removestartup_script_behaviour.

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

a few more suggestions.

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
@mafredri
Copy link
Member

We should then also removestartup_script_behaviour.

We could, but then we must rewrite allstartup_script entries ascoder_script resources with the matching blocking setting.

matifali reacted with thumbs up emoji

@johnstcnjohnstcn merged commit1cc51b0 intomainFeb 12, 2024
@johnstcnjohnstcn deleted the cj/rm-startup-script-timeout branchFebruary 12, 2024 14:29
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@mafredrimafredrimafredri approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@mafredri@matifali@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp