Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Update generated schema for provisionerd#121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromprovisionerschema
Feb 1, 2022

Conversation

kylecarbs
Copy link
Member

These changes were part of a bulk change to create provisionerd.
They were ripped out for simpler reviewing.

@codecov
Copy link

codecovbot commentedFeb 1, 2022
edited
Loading

Codecov Report

Merging#121 (b37edc2) intomain (bf90ded) willincrease coverage by0.34%.
The diff coverage is79.24%.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #121      +/-   ##==========================================+ Coverage   71.90%   72.24%   +0.34%==========================================  Files          91       91                Lines        3670     3751      +81       Branches       59       59              ==========================================+ Hits         2639     2710      +71- Misses        814      824      +10  Partials      217      217
FlagCoverage Δ
unittest-go-macos-latest68.45% <ø> (+0.44%)⬆️
unittest-go-ubuntu-latest70.54% <79.24%> (+0.76%)⬆️
unittest-go-windows-latest67.86% <ø> (+0.17%)⬆️
unittest-js74.72% <ø> (ø)
Impacted FilesCoverage Δ
provisioner/terraform/provision.go73.68% <78.49%> (+16.05%)⬆️
provisioner/terraform/parse.go78.18% <84.61%> (+3.18%)⬆️
peer/channel.go84.75% <0.00%> (-2.44%)⬇️
peer/conn.go79.42% <0.00%> (-0.79%)⬇️
peerbroker/listen.go84.80% <0.00%> (+2.39%)⬆️
peerbroker/dial.go80.95% <0.00%> (+4.76%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatebf90ded...b37edc2. Read thecomment docs.

These changes were part of a bulk change to create provisionerd.They were ripped out for simpler reviewing.
deferreader.Close()
deferwriter.Close()
gofunc() {
decoder:=json.NewDecoder(reader)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like we're getting really close to being able to stream the terraform logs 🎉

before_id uuid,
after_id uuid,
transition workspace_transitionNOT NULL,
initiatorvarchar(255)NOT NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unrelated to this PR, but it reminded me - what are values forinitiator like? Is it supposed to reference the user that initiated the transition, or something else?

@kylecarbskylecarbs merged commitac617e1 intomainFeb 1, 2022
@kylecarbskylecarbs deleted the provisionerschema branchFebruary 1, 2022 05:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@bryphe-coderbryphe-coderbryphe-coder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kylecarbskylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylecarbs@bryphe-coder

[8]ページ先頭

©2009-2025 Movatter.jp