- Notifications
You must be signed in to change notification settings - Fork928
fix: allow access to unhealthy/initializing apps#12086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
spikecurtis approved these changesFeb 12, 2024
Uh oh!
There was an error while loading.Please reload this page.
| return nil, "", false | ||
| } | ||
| // This is where we used to check app health, but we don't do that anymore | ||
| // in case there are bugs with the healthcheck code that lock users out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| // in case there are bugs with the healthcheckcodethat lock users out of | |
| // in case there are bugs with the healthcheck that lock users out of |
could be a lot of things: misconfiguration, app healthcheck endpoint could be misbehaving
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the healthcheck code fails, we don't want to lock users out of their apps as there are no workarounds without downloading the CLI.