Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(cli/server): do not redirect /healthz#12080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/no-redirect-healthz
Feb 9, 2024

Conversation

johnstcn
Copy link
Member

If you set--redirect-access-url=true, then you would have seen these warnings from Kubelet:

   Warning  ProbeWarning  5m52s (x121 over 25m)  kubelet            Liveness probe warning: Probe terminated redirects, Response body: <a href="https://dev.coder.com">Temporary Redirect</a>.                                             ││   Warning  ProbeWarning  52s (x152 over 26m)    kubelet            Readiness probe warning: Probe terminated redirects, Response body: <a href="https://dev.coder.com">Temporary Redirect</a>.

We have specific checks for/derp to not redirect in this case, so extending this for/healthz.

@johnstcnjohnstcn self-assigned thisFeb 9, 2024
@johnstcnjohnstcn requested a review frommtojekFebruary 9, 2024 12:44
@johnstcnjohnstcn merged commit2b307c7 intomainFeb 9, 2024
@johnstcnjohnstcn deleted the cj/no-redirect-healthz branchFebruary 9, 2024 13:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp