Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Update buildinfo package location in ldflags#1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfrombuildtag
Apr 28, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This was causing the version to not be injected!

This was causing the version to not be injected!
@kylecarbskylecarbs self-assigned thisApr 28, 2022
@kylecarbskylecarbsenabled auto-merge (squash)April 28, 2022 14:36
@codecov
Copy link

codecovbot commentedApr 28, 2022•
edited
Loading

Codecov Report

Merging#1208 (5b6942c) intomain (816441e) willincrease coverage by0.11%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1208      +/-   ##==========================================+ Coverage   66.00%   66.12%   +0.11%==========================================  Files         265      265                Lines       16751    16751                Branches      157      157              ==========================================+ Hits        11057    11076      +19+ Misses       4533     4521      -12+ Partials     1161     1154       -7
FlagCoverage Δ
unittest-go-macos-latest53.59% <ø> (+0.13%)⬆️
unittest-go-postgres-65.30% <ø> (+0.05%)⬆️
unittest-go-ubuntu-latest56.03% <ø> (+0.01%)⬆️
unittest-go-windows-202253.07% <ø> (+0.01%)⬆️
unittest-js66.50% <ø> (ø)
Impacted FilesCoverage Δ
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
coderd/provisionerdaemons.go62.28% <0.00%> (-0.51%)⬇️
provisioner/echo/serve.go56.80% <0.00%> (ø)
peer/conn.go81.72% <0.00%> (+0.25%)⬆️
coderd/workspaceagents.go55.59% <0.00%> (+0.95%)⬆️
provisionerd/provisionerd.go77.91% <0.00%> (+1.74%)⬆️
coderd/httpapi/httpapi.go72.50% <0.00%> (+6.25%)⬆️
provisionersdk/serve.go43.24% <0.00%> (+8.10%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update816441e...5b6942c. Read thecomment docs.

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oops my bad! Nice find!

@kylecarbskylecarbs merged commiteea9729 intomainApr 28, 2022
@kylecarbskylecarbs deleted the buildtag branchApril 28, 2022 15:46
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This was causing the version to not be injected!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp