- Notifications
You must be signed in to change notification settings - Fork928
feat: handle log limit exceeded in logSender#12079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
spikecurtis merged 1 commit intospike/10534-log-senderfromspike/10534-log-sender-handle-log-limit-exceededFeb 9, 2024
Merged
feat: handle log limit exceeded in logSender#12079
spikecurtis merged 1 commit intospike/10534-log-senderfromspike/10534-log-sender-handle-log-limit-exceededFeb 9, 2024
+85 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedFeb 9, 2024
ContributorAuthor
spikecurtis commentedFeb 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
15855f4 to3047485Compare89ce3e7 toc8e7282Compare3047485 toad9d94aComparec8e7282 to0515169CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Modify the logSender to gracefully handle the log limit being exceeded on the server side.
Here we just drop a warning in the Coder agent log and then silently discard all new logs, since the server won't accept them.