Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: supportorder property ofcoder_app resource#12077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 16 commits intomainfrom8994-order-coder-app-1
Feb 12, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedFeb 9, 2024•
edited
Loading

Fixes:#8994

This PR adjusts logic to sortcoder_apps to preserve predefined order. Only custom apps are sorted, VS Code and Terminal stay as is.

Screenshot 2024-02-12 at 14 00 49

@mtojekmtojek self-assigned thisFeb 9, 2024
@matifali
Copy link
Member

@mtojek How will it affect thebultin coder_apps? Is the order controllable for them?

@mtojek
Copy link
MemberAuthor

You can only control custom ones, so it would be:

  1. VS Codebuttons...
  2. Custom apps sorted by order
  3. Terminal.

I can move Terminal to the 2nd position so that custom apps are aside. I'm happy to modify this idea if you have any proposals.

matifali reacted with thumbs up emoji

@matifali
Copy link
Member

Sounds good. I think there is no need to change anything.

mtojek reacted with hooray emoji

@mtojekmtojek marked this pull request as ready for reviewFebruary 12, 2024 14:04
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@mtojekmtojek merged commit3e68650 intomainFeb 12, 2024
@mtojekmtojek deleted the 8994-order-coder-app-1 branchFebruary 12, 2024 14:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addorder tocoder_app resource
3 participants
@mtojek@matifali@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp