Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support custom order of agent metadata#12066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 12 commits intomainfrom8487-metadata-order-coder
Feb 8, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedFeb 8, 2024•
edited
Loading

Fixes:#8487

This PR modifies the logic responsible for sorting agent metadata items to consider custom ordering, not just keys.

@mtojekmtojek self-assigned thisFeb 8, 2024
@mtojekmtojek requested a review fromjohnstcnFebruary 8, 2024 15:14
@mtojekmtojek marked this pull request as ready for reviewFebruary 8, 2024 15:14
stringscript=3;
int64interval=4;
int64timeout=5;
int64order=6;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunate that it generates an int64 here for an int32 :\

Copy link
MemberAuthor

@mtojekmtojekFeb 8, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, this is unfortunate. It is aligned withcoder_parameter display order type though.

@mtojekmtojek marked this pull request as draftFebruary 8, 2024 15:41
@mtojek
Copy link
MemberAuthor

Taking back to draft, as I can't update the workspace after removingorder property from the template:

Terraform 1.7.1-devcoder_agent.main: Plan to updatedocker_container.workspace[0]: Plan to replacedocker_container.workspace[0]: Destroying... [id=a8736e982bf07b30de62933b4fcc332b60cab345da4b329778ffa6c39920f404]docker_container.workspace[0]: Destruction complete after 1scoder_agent.main: Modifying... [id=6cf9db01-93be-4b6a-af76-194a82f64dde]coder_agent.main: Modifications errored after 0sError: doesn't support updateon main.tf line 408, in resource "coder_agent" "main":  408: resource "coder_agent" "main" {Cleaning Up

@mtojekmtojek marked this pull request as ready for reviewFebruary 8, 2024 16:20
@mtojekmtojek merged commitc0e169e intomainFeb 8, 2024
@mtojekmtojek deleted the 8487-metadata-order-coder branchFebruary 8, 2024 16:29
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Addorder tocoder_agent'smetadata fields

2 participants

@mtojek@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp