Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add filter by status on GET /users#1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 12 commits intomainfrombq/return-only-active-users
Apr 29, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Discussion:#662 (comment)

Reason: The FE needs to get only the active users for now, so I think the best way for doing that is to add a filter on the GET /users endpoint so the FE can do /users?status=active.

@BrunoQuaresmaBrunoQuaresma requested a review froma teamApril 28, 2022 13:19
@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 28, 2022
@BrunoQuaresma
Copy link
CollaboratorAuthor

@presleyp this is a bit different from what we discussed in the epic but I think it is better since allows us to easily filter users using other statuses. What do you think?

@codecov
Copy link

codecovbot commentedApr 28, 2022•
edited
Loading

Codecov Report

Merging#1206 (4a7ffd6) intomain (1661588) willincrease coverage by0.21%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1206      +/-   ##==========================================+ Coverage   65.48%   65.69%   +0.21%==========================================  Files         265      268       +3       Lines       16950    17020      +70       Branches      157      162       +5     ==========================================+ Hits        11099    11182      +83+ Misses       4692     4678      -14- Partials     1159     1160       +1
FlagCoverage Δ
unittest-go-macos-latest53.00% <87.50%> (+0.12%)⬆️
unittest-go-postgres-64.65% <100.00%> (-0.05%)⬇️
unittest-go-ubuntu-latest55.34% <87.50%> (-0.11%)⬇️
unittest-go-windows-202252.48% <87.50%> (-0.02%)⬇️
unittest-js68.85% <ø> (+2.35%)⬆️
Impacted FilesCoverage Δ
coderd/database/queries.sql.go81.13% <100.00%> (+0.01%)⬆️
coderd/users.go61.00% <100.00%> (+0.13%)⬆️
codersdk/users.go64.40% <100.00%> (+0.20%)⬆️
site/src/xServices/StateContext.tsx92.30% <0.00%> (-7.70%)⬇️
coderd/httpapi/httpapi.go66.25% <0.00%> (-6.25%)⬇️
site/src/xServices/users/usersXService.ts81.25% <0.00%> (-4.47%)⬇️
peerbroker/listen.go87.39% <0.00%> (-3.37%)⬇️
provisioner/echo/serve.go56.80% <0.00%> (-2.41%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
site/src/pages/UsersPage/UsersPage.tsx82.35% <0.00%> (-0.99%)⬇️
... and18 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1661588...4a7ffd6. Read thecomment docs.

@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerApril 28, 2022 13:22
Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah that approach works for me!

BrunoQuaresma reacted with heart emoji
@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)April 28, 2022 19:14
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

1 last comment

BrunoQuaresma reacted with eyes emoji
@BrunoQuaresmaBrunoQuaresma merged commitba4c3ce intomainApr 29, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/return-only-active-users branchApril 29, 2022 13:29
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

4 participants
@BrunoQuaresma@presleyp@Emyrk@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp