- Notifications
You must be signed in to change notification settings - Fork928
feat!: update terraform to version 1.6.x, relax max version constraint#12027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -26,9 +26,7 @@ RUN apk add --no-cache \ | |||
| # Terraform was disabled in the edge repo due to a build issue. | |||
| # https://gitlab.alpinelinux.org/alpine/aports/-/commit/f3e263d94cfac02d594bef83790c280e045eba35 | |||
| # Using wget for now. Note that busybox unzip doesn't support streaming. | |||
| # | |||
| # WARNING: Do not update to 1.6.x, as it is the first release licensed under BSL instead of MPL. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We're OK with this from a legal standpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah we're good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm fine with this change, although it would be great to get 👍 from leadership on the legal side too.
Uh oh!
There was an error while loading.Please reload this page.
Why not go to 1.7.x? |
Our current default is 1.4.6, and going to 1.6.6 is already a big jump. |
Yeah, I think jumping to 1.6.x first is the play here |
I'm going to hold off on merging this until@bpmct gives the green light. I'd feel most comfortable doing this right after the next release so that we have a good deal of time to iron out any issues we run into on dogfood. |
I am personally using 1.7.x on one of my deployments (coder Deb package and tarraform installed manually) and so far no issues. But I agree we should do it after the release. |
@johnstcn I have terraform 1.7.2 and Coder seems to work even though it's outside of the max version. Shouldn't the builds fail in this case? |
johnstcn commentedFeb 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It should download the 'known good' Terraform version in this case. You can check the build logs of a workspace for the Terraform version string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Approved
Uh oh!
There was an error while loading.Please reload this page.
Relates to#12009
This should allow both us and others to experiment more easily with newer versions of Terraform.
Marking this as a breaking change so that it's called out prominently in the release notes.