Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for optional external auth providers#12021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 35 commits intomainfromoptional-external-auth
Feb 21, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedFeb 5, 2024
edited
Loading

Screenshot 2024-02-14 at 4 34 01 PM

(screenshot includes frontend changes that will be landing in a separate pull request, because this one is already big enough 😄)

Part of#10109

  • Migrateexternal_auth_providers column in the database, in order to be able to contain metadata about providers, such as settings/attributes defined in Terraform.
  • Add support forexternal_auth_provider.optional in the Terraform provisioner and provisionerd
  • Addoptional toTemplateVersionExternalAuth
    • and fill it with new database goodness when querying/templateversions/{templateversion}/external-auth

TODO

  • who usesproto.CurrentVersion? there are some tests failing because of this, and I'm not really sure what to do about it
    • also it doesn't seem like there's any machinery for checking the terraform provider version? kind of unfortunate that you could just start using 0.16 with an old version of coder andoptional would just silently disappear

@aslilacaslilac marked this pull request as ready for reviewFebruary 15, 2024 20:21
@kylecarbs
Copy link
Member

Regarding this UX, should we revert to the old UI? The "Connect" button with "Optional" and then also presumably a "Skip" feels like a lot.

@aslilac
Copy link
MemberAuthor

aslilac commentedFeb 15, 2024
edited
Loading

Regarding this UX, should we revert to the old UI? The "Connect" button with "Optional" and then also presumably a "Skip" feels like a lot.

it sounds like everyone is in favor of a revert. the screenshot is of some very very placeholder coder for testing that isn't even in this pr. the frontend stuff will be a separate pr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

heads-up: just before you merge, double-check the latest migration number onmain

@aslilacaslilac merged commit475c365 intomainFeb 21, 2024
@aslilacaslilac deleted the optional-external-auth branchFebruary 21, 2024 18:18
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 21, 2024
@aslilacaslilac linked an issueFeb 21, 2024 that may beclosed by this pull request
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis is a code owner

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make external auth providers optional
4 participants
@aslilac@kylecarbs@johnstcn@spikecurtis

[8]ページ先頭

©2009-2025 Movatter.jp