- Notifications
You must be signed in to change notification settings - Fork928
feat: add support for optional external auth providers#12021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b83538b
to179adae
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Regarding this UX, should we revert to the old UI? The "Connect" button with "Optional" and then also presumably a "Skip" feels like a lot. |
aslilac commentedFeb 15, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
it sounds like everyone is in favor of a revert. the screenshot is of some very very placeholder coder for testing that isn't even in this pr. the frontend stuff will be a separate pr. |
coderd/database/migrations/000194_external_auth_providers_jsonb.up.sql OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
heads-up: just before you merge, double-check the latest migration number onmain
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
(screenshot includes frontend changes that will be landing in a separate pull request, because this one is already big enough 😄)
Part of#10109
external_auth_providers
column in the database, in order to be able to contain metadata about providers, such as settings/attributes defined in Terraform.external_auth_provider.optional
in the Terraform provisioner and provisionerdoptional
toTemplateVersionExternalAuth
/templateversions/{templateversion}/external-auth
TODO
proto.CurrentVersion
? there are some tests failing because of this, and I'm not really sure what to do about itoptional
would just silently disappear