Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): allow any file extension on template editor#12000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 20 commits intomainfrombq/template-editor
Feb 7, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedFeb 2, 2024•
edited
Loading

  • Accepts any file extension on the template editor
  • Keep the version updated in the URL so the page does not lose state
  • Keep the active file in the URL so it is "shareable" and does not lose state on refresh
Screen.Recording.2024-02-02.at.14.04.02.mov
Screen.Recording.2024-02-05.at.14.30.15.mov

@matifali I really would appreciate a rough QA on this 🙏

matifali reacted with thumbs up emoji
@BrunoQuaresma
Copy link
CollaboratorAuthor

I still need to refactor the TemplateFilesPage.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedFeb 3, 2024•
edited
Loading

✔️ PR 12000 Updated successfully.
🚀 Access the credentialshere.

cc:@BrunoQuaresma

github-actions[bot] reacted with rocket emoji

@BrunoQuaresmaBrunoQuaresma changed the titleWIP: feat(site): allow any file extension on template editorfeat(site): allow any file extension on template editorFeb 6, 2024
@BrunoQuaresmaBrunoQuaresma requested review froma team andaslilac and removed request fora teamFebruary 6, 2024 11:18
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thoughts based on videos you posted:

  1. Could we join directories without files? For example,usr/share/keyrings instead of:
Screenshot 2024-02-06 at 16 09 41

Definitely, less clicking.

  1. Can you try with relatively long names and deep, deep directories?

  2. Can we grey out hidden files, so ones starting with a dot?

@BrunoQuaresma
Copy link
CollaboratorAuthor

  1. I like the idea! Let me see if I can extend this component to support this.
  2. This is going to generate horizontal scrolling like happens with VSCode and any IDE editor. Thoughts?
  3. If by "hidden files" you mean folders or files that start with a dot, we can do it easily.

@mtojek
Copy link
Member

This is going to generate horizontal scrolling like happens with VSCode and any IDE editor. Thoughts?

It might be inevitable in this case, not sure if there is a better way to show it in UI :)

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for addressing feedback!

@BrunoQuaresmaBrunoQuaresma merged commit4b1bac3 intomainFeb 7, 2024
@BrunoQuaresmaBrunoQuaresma deleted the bq/template-editor branchFebruary 7, 2024 16:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 7, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@mtojekmtojekmtojek approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@mtojek@matifali
[8]ページ先頭
©2009-2025 Movatter.jp