Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add port-sharing backend#11939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 82 commits intomainfromf0ssel/port-sharing-1
Feb 13, 2024
Merged

feat: add port-sharing backend#11939

f0ssel merged 82 commits intomainfromf0ssel/port-sharing-1
Feb 13, 2024

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedJan 30, 2024•
edited
Loading

Closes#11845
Closes#11846
Closes#11849
Closes#11850
Closes#11854

I'm doing these together so I can deliver a basic API that respects both AGPL and Enterprise.

AGPL

  • Allow all levels of port sharing

Enterprise

  • Templates now have a configuration for max port sharing level, uses the template metadata edit API

@f0sself0ssel changed the titlefeat: add post port-sharing levelfeat: add port-sharing levelJan 30, 2024
@f0sself0ssel marked this pull request as ready for reviewFebruary 5, 2024 20:10
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs integration tests, you can add them to theapptest package

@deansheatherdeansheather self-requested a reviewFebruary 9, 2024 15:42
@f0sself0ssel merged commit3ab3a62 intomainFeb 13, 2024
@f0sself0ssel deleted the f0ssel/port-sharing-1 branchFebruary 13, 2024 14:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees

@f0sself0ssel

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@f0ssel@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp