Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove agentsdk client RPC() function#11913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/10534-remove-rpc-method
Feb 1, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJan 30, 2024
edited
Loading

The RPC() function isn't called, since Listen() was modified to do this job.

Listen() has the right signature, since it returns a drpc.Conn, rather than the Agent API. That's because tailnet v2 and agent v2 are separate APIs served over the same connection.

It might be clearer to renameListen() toRPC() but I'll save that for a different PR.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJan 30, 2024
edited
Loading

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedFeb 1, 2024
edited
Loading

Merge activity

  • Jan 31, 11:21 PM EST America/New_York:@spikecurtis started a stack merge that includes this pull request viaGraphite.
  • Jan 31, 11:22 PM EST America/New_York:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis merged commitcc0dc10 intomainFeb 1, 2024
@spikecurtisspikecurtis deleted the spike/10534-remove-rpc-method branchFebruary 1, 2024 04:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherAwaiting requested review from deansheather

1 more reviewer

@coadlercoadlercoadler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@coadler

[8]ページ先頭

©2009-2025 Movatter.jp