- Notifications
You must be signed in to change notification settings - Fork928
fix(site): fix parameters' request upon template variables update#11898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <Fragment key={k}> | ||
| {k === "scope" ? ( | ||
| <ProvisionerTagkey={k}k={k} v={tags[k]} /> | ||
| <ProvisionerTag k={k} v={tags[k]} /> | ||
| ) : ( | ||
| <ProvisionerTag | ||
| key={k} | ||
| k={k} | ||
| v={tags[k]} | ||
| onDelete={onDelete} | ||
| /> | ||
| <ProvisionerTag k={k} v={tags[k]} onDelete={onDelete} /> | ||
| )} | ||
| </> | ||
| </Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this doesn't even need to be a fragment, both branches only return one element. I guess it's nice to only specify the key in one place tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes!
Fix#11870