Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): display user avatar#11893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 9 commits intomainfrombq/replace-user-icon-by-avatar
Jan 30, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedJan 29, 2024•
edited by matifali
Loading

Close#11437

Before:
Screenshot 2024-01-29 at 11 22 45

After:
Screenshot 2024-01-29 at 11 22 50

matifali, MrPeacockNLB, and Parkreiner reacted with thumbs up emoji
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have a look at the failing tests. I think your refactor is causing theUsername field to be blank.

@mtojek
Copy link
Member

Reviewing now.

@johnstcnjohnstcn self-assigned thisJan 30, 2024
@johnstcnjohnstcn requested review frommafredri and removed request forspikecurtisJanuary 30, 2024 15:17
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@johnstcnjohnstcn merged commitdcab6fa intomainJan 30, 2024
@johnstcnjohnstcn deleted the bq/replace-user-icon-by-avatar branchJanuary 30, 2024 17:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn left review comments

@mtojekmtojekmtojek approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Display user avatar on workspace top bar instead of a generic icon

3 participants

@BrunoQuaresma@mtojek@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp