Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: fix winget-release workflow#11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 3 commits intomainfrommatifali/ci-winget-release-fix
Jan 29, 2024
Merged

Conversation

matifali
Copy link
Member

@matifalimatifali commentedJan 27, 2024
edited
Loading

Closes#11842
Based on the same idea as inmicrosoft/devhome#2167

@matifalimatifali self-assigned thisJan 27, 2024
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable to me.

@matifali
Copy link
MemberAuthor

@mdanish-kh, I would appreciate it if you could look before I merge this.

mdanish-kh reacted with thumbs up emoji

@matifalimatifali added the block-releaseAdd this label to a PR to prevent a new release until the PR is merged. Only humans may set this. labelJan 29, 2024
Copy link
Contributor

@mdanish-khmdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thisshould resolve winget-create's failure (although I haven't been able to test it out). I would suggest kicking off a re-run after merging this, the PR won't get created since Coderv2.7.2 is already in the repo, but we would be able to see if the original error reproduces or not.

matifali reacted with thumbs up emoji
@matifalimatifali merged commit8398b41 intomainJan 29, 2024
@matifalimatifali deleted the matifali/ci-winget-release-fix branchJanuary 29, 2024 10:49
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 29, 2024
@matifali
Copy link
MemberAuthor

A rerun of thefailed workflow will not use the latest version. The release workflow only gets triggered on a release. So let's see what happens.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mdanish-khmdanish-khmdanish-kh approved these changes

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@matifalimatifali

Labels
block-releaseAdd this label to a PR to prevent a new release until the PR is merged. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci(release): Sync winget-pkgs fork before publishing
3 participants
@matifali@johnstcn@mdanish-kh

[8]ページ先頭

©2009-2025 Movatter.jp