Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(coderd/rbac): do not cache context cancellation errors#11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/rbac-do-not-cache-non-rbac-errors
Jan 26, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJan 26, 2024
edited
Loading

Should hopefully un-break#11800

#7439 added global caching of RBAC results.
Calls are cached based onhash(subject, object, action).
We often usedbauthz.AsSystemRestricted to handle "internal" authz calls, and these are often repeated with similar arguments and are likely to get cached.
So a transient error doing an authz check on a system function will be cached for up to a minute.
I'm just starting off with excludingcontext.Canceled but there's likely a whole suite of different errors we want to also exclude from the global cache.

@johnstcnjohnstcn self-assigned thisJan 26, 2024
@johnstcnjohnstcn marked this pull request as ready for reviewJanuary 26, 2024 15:01
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a great find 👍

@johnstcnjohnstcn merged commit42e997d intomainJan 26, 2024
@johnstcnjohnstcn deleted the cj/rbac-do-not-cache-non-rbac-errors branchJanuary 26, 2024 16:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EmyrkEmyrkEmyrk approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnstcn@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp