- Notifications
You must be signed in to change notification settings - Fork1k
chore: move proto to sdk conversion to agentsdk#11831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 26, 2024
ContributorAuthor
spikecurtis commentedJan 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
This was referencedJan 26, 2024
6fcd156 to1f928bdCompared5955e3 to531707cCompare1f928bd to395f862Compare531707c to60b8ac5Compare395f862 to5798ab2Compare60b8ac5 to669395fCompare5798ab2 to903844aCompare669395f tof0467b1Compare903844a tofa421d2Comparef0467b1 to9233e88Comparedeansheather approved these changesJan 29, 2024
fa421d2 to557df04Compare9233e88 toa0f3144Compare557df04 to1444befComparea0f3144 to134b25dCompareContributorAuthor
spikecurtis commentedJan 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
agentsdkdepends onagent/protobecause it needs to get the version to dial.Therefore, the conversion routines need to live in
agentsdkso that we can convert to and from the Manifest.I briefly considered refactoring the agent to only reference
proto.Manifest, but decided against it because we might have multiple protocol versions in the future, its useful to have a protocol-independent data structure.