Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: always attempt external auth refresh when fetching (#11762)#11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromstevenmasley/external_auth_refresh_2
Jan 29, 2024

Conversation

Emyrk
Copy link
Member

  • fix: always attempt external auth refresh when fetching
  • refactor validate to check expiry when considering "valid"

Original:#11762
Revert:79568bf

Reported error

Using github as login.

{"message":"Internal error fetching authenticated Github user organizations.","detail":"GET https://api.github.com/user/memberships/orgs?per_page=100\u0026state=active: 401 Bad credentials []"}

I cannot reproduce this, nor do I see how this commit affects listing github user organizations.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJan 26, 2024•
edited
Loading

✔️ PR 11830 Updated successfully.
🚀 Access the credentialshere.

cc:@Emyrk

github-actions[bot] reacted with rocket emoji

@EmyrkEmyrk marked this pull request as ready for reviewJanuary 26, 2024 16:16
* fix: always attempt external auth refresh when fetching* refactor validate to check expiry when considering "valid"
@EmyrkEmyrkforce-pushed thestevenmasley/external_auth_refresh_2 branch from5b0d243 toc872363CompareJanuary 26, 2024 16:39
@Emyrk
Copy link
MemberAuthor

No 401s detected (as originally reported) since this has been on dogfood (Jan 26)

Screenshot from 2024-01-29 08-51-08

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

dogfood was left running with this commit over the weekend and we were not able to reproduce the issue. I don't believe this commit was related to the issues we saw.

Emyrk reacted with thumbs up emoji
@EmyrkEmyrk merged commitd66e6e7 intomainJan 29, 2024
@EmyrkEmyrk deleted the stevenmasley/external_auth_refresh_2 branchJanuary 29, 2024 14:55
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Emyrk@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp