- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: remove legacy wsconncache#11816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 25, 2024
ContributorAuthor
spikecurtis commentedJan 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
ca4dd7a to00d8daaCompare4dc08bc to6e7e25fCompare6e7e25f toc4af306Compare00d8daa todca0e6cComparec4af306 to4579eaeComparedca0e6c to6fcd156Compare This was referencedJan 26, 2024
6fcd156 to1f928bdCompare4579eae to7961d48Compare1f928bd to395f862Comparecoadler approved these changesJan 26, 2024
Uh oh!
There was an error while loading.Please reload this page.
7961d48 to04cdbc1Compare395f862 to5798ab2Compare04cdbc1 to320f232Compare5798ab2 to903844aCompare320f232 to492a7d4Compare903844a tofa421d2Comparedeansheather approved these changesJan 29, 2024
492a7d4 toa401924Comparefa421d2 to557df04Compare557df04 to1444befCompareContributorAuthor
spikecurtis commentedJan 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#8218
Removes
wsconncacheand related "is legacy?" functions and API calls that were used by it.The only leftover is that Agents still use the legacy IP, so that back level clients or workspace proxies can dial them correctly.
We should eventually remove this:#11819