Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: use map instead of slice in metrics aggregator#11815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 7 commits intomainfrom11775-cpu
Jan 29, 2024
Merged

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedJan 25, 2024•
edited
Loading

Related:#11775

This PR modifies the internals ofMetricsAggregator:

  • increase the size ofupdateCh to 4096.
  • use map instead of slice to keep track of metrics
  • add gauge to expose the size of store as Prometheus metric.

@mtojekmtojek self-assigned thisJan 25, 2024
@mtojekmtojek marked this pull request as ready for reviewJanuary 25, 2024 11:12
@mtojekmtojek changed the titlefeat: use map instead slice in metrics aggregatorfeat: use map instead of slice in metrics aggregatorJan 25, 2024
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice refactor! A few suggestions but otherwise LGTM.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@mtojekmtojek merged commitaacb4a2 intomainJan 29, 2024
@mtojekmtojek deleted the 11775-cpu branchJanuary 29, 2024 08:12
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mtojek@mafredri@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp