Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd/provisionerdserver): fix test flake in TestHeartbeat#11808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 4 commits intomainfromcj/flake-provisionerdserver-heartbeat
Jan 25, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJan 24, 2024•
edited
Loading

Fixes a test flake seen here:https://github.com/coder/coder/actions/runs/7640549172/job/20815906797#step:5:431

I instead added a channel toheartbeatLoop to ensure that heartbeats are stopped when the ctx is cancelled. Edit: now relying on goleak to ensure that the heartbeat loop is stopped.

@johnstcnjohnstcn self-assigned thisJan 24, 2024
Copy link
Contributor

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One nit about context timeout inline, but I don't need to review again

@johnstcnjohnstcn merged commit8eae4f8 intomainJan 25, 2024
@johnstcnjohnstcn deleted the cj/flake-provisionerdserver-heartbeat branchJanuary 25, 2024 12:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnstcn@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp