- Notifications
You must be signed in to change notification settings - Fork913
feat: use Agent v2 API for Service Banner#11806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 24, 2024
ContributorAuthor
spikecurtis commentedJan 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
cfe6dcc to6f243f6Compare368f754 to4dc08bcCompare4dc08bc to6e7e25fCompare6f243f6 toa85394dCompare6e7e25f toc4af306Comparea85394d to1c21905Comparec4af306 to4579eaeCompare This was referencedJan 26, 2024
1c21905 to98ab55eCompare4579eae to7961d48Compare98ab55e to174664cCompare7961d48 to04cdbc1Compare174664c to385e74aCompare04cdbc1 to320f232Compare385e74a to43a1c9eCompare320f232 to492a7d4Comparedeansheather approved these changesJan 29, 2024
| @@ -254,3 +246,73 @@ type closeFunc func() error | |||
| func (c closeFunc) Close() error { | |||
| return c() | |||
| } | |||
| type FakeAgentAPI struct { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you generate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could generate it as a Mock, but that won't fit as easily into our existing tests.
492a7d4 toa401924CompareMerge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Agent uses the v2 API for the service banner, rather than the v1 HTTP API.
One of several for#10534