- Notifications
You must be signed in to change notification settings - Fork924
feat(cli): add favorite/unfavorite commands#11793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| buf.Reset() | ||
| inv, root = clitest.New(t, "unfavorite", ws.Workspace.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What will happen if a user marks their workspace as "favorite" twice? Is it relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nothing interesting really will happen. It'll get updated again, which is essentially a no-op. We could check if the workspace is already favorited, but the overhead probably isn't worth the effort.
6c20099 to0cc97bbCompare
Part of#7912
Depends on#11791
Adds CLI commands allowing users to add/remove workspaces from their favorites.