Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: stop spamming DERP map updates for equivalent maps#11792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/fix-derp-spam
Jan 24, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJan 24, 2024
edited
Loading

Fixes 2 related issues:

  1. wsconncache had incorrect logic to test whether to send DERPMap updates, sending if the maps were equivalent, instead of if they werenot equivalent.
  2. configmaps used a bugged check to test equality between DERPMaps, since it contains a map and the map entries are serialized in random order. Instead, we avoid comparing the protobufs and instead depend on the existing function that comparestailcfg.DERPMap. This also has the effect of reducing the number of times we convert to and from protobuf.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJan 24, 2024
edited
Loading

@spikecurtisspikecurtis marked this pull request as ready for reviewJanuary 24, 2024 10:30
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Syntactically correct, but I'm not super familiar with the tailnet code internals. Thanks for addressing the issue!

@spikecurtisspikecurtis merged commit5cbb76b intomainJan 24, 2024
@spikecurtisspikecurtis deleted the spike/fix-derp-spam branchJanuary 24, 2024 12:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp