- Notifications
You must be signed in to change notification settings - Fork928
docs: simplify JFrog integration docs#11787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
17 commits Select commitHold shift + click to select a range
f7f28c7
Update jfrog.md
matifali5a7e7b8
formatting and typos
matifali4bd4ff0
move to guides
matifali4a86f6d
review comments
matifalib2d99a9
Update jfrog.md
matifali80d94a9
add configure-code-server
matifali0745274
add manifest and rename
matifalic36c574
update
matifali7b32f44
`fmt`
matifali03b3fd2
rename
matifali3fe5896
reorganize
matifalib77b494
fixup!
matifali94f8b6f
refactor
matifalibc1672e
Update JFrog integration instructions
matifali5c7ef15
fmt
matifali2e143d9
Update Artifactory integration instructions
matifali3b5bc0a
fmt
matifaliFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
formatting and typos
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit5a7e7b8c0dbe92f12ccfdbbe499e4889bf0f7acf
There are no files selected for viewing
41 changes: 26 additions & 15 deletionsdocs/platforms/jfrog.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -18,26 +18,24 @@ The full example template can be found | ||
- Repositories configured in Artifactory for each package manager you want to | ||
use | ||
## Provisioner Authentication | ||
The most straight-forward way to authenticate your template with Artifactory is | ||
by using our official Coder [modules](rhttps://egistry.coder.com). We publish | ||
matifali marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
two type of modules that automate the JFrog Artifactory and Coder integration. | ||
1. JFrog-OAuth: | ||
2. JFrog-Token: | ||
### JFrog-OAuth | ||
This module is usable by Jfrog self-hosted (on-premises) Artifactory as it | ||
matifali marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
requires configuring a custom integration. This integration benefits from | ||
Coder's [external-auth](https://coder.com/docs/v2/latest/admin/external-auth) | ||
feature and allows each user to authenticate with Artifactory using an OAuth | ||
flow and issues user-scoped tokens to each user. For instructions on how to set | ||
this up, please see the details at: | ||
https://registry.coder.com/modules/jfrog-oauth | ||
```hcl | ||
module "jfrog" { | ||
@@ -56,7 +54,13 @@ module "jfrog" { | ||
### JFrog-Token | ||
This module makes use of the | ||
[Artifactory terraform provider](https://registry.terraform.io/providers/jfrog/artifactory/latest/docs) | ||
and an admin-scoped token to create user-scoped tokens for each user by matching | ||
their Coder email or username with Artifactory. This can be used for both SaaS | ||
and self-hosted(on-premises) Artifactory instances. For Instructions on how to | ||
configure this, please see the details at: | ||
https://registry.coder.com/modules/jfrog-token | ||
```hcl | ||
module "jfrog" { | ||
@@ -73,9 +77,16 @@ module "jfrog" { | ||
} | ||
``` | ||
<blockquote class="info"> | ||
The admin-level access token is used to provision user tokens and is never exposed to | ||
developers or stored in workspaces. | ||
</blockquote> | ||
## Offline Deployments | ||
See the [offline deployments](../install/offline.md#coder-modules) guide for | ||
instructions on how to use coder-modules in an offline environment with | ||
Artifactory. | ||
## More reading | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.