Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: build & release cross-platform Docker images#1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 8 commits intomainfrombpmct/dockerfile
May 12, 2022

Conversation

bpmct
Copy link
Member

@bpmctbpmct commentedApr 25, 2022•
edited
Loading

This PR will build cross-platform docker images for each release. Contributions are welcome!

Subtasks

  • create Dockerfile
  • create docker-compose will leave this for the Docs
  • build cross-platform images in goreleaser (this tutorial looks nice. I'll also look into how we do it for code-server

Fixes#1177

@codecov
Copy link

codecovbot commentedApr 25, 2022•
edited
Loading

Codecov Report

Merging#1178 (0df2fe6) intomain (f581724) willincrease coverage by0.04%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1178      +/-   ##==========================================+ Coverage   66.97%   67.02%   +0.04%==========================================  Files         288      285       -3       Lines       18857    19022     +165       Branches      241      241              ==========================================+ Hits        12630    12750     +120- Misses       4939     4951      +12- Partials     1288     1321      +33
FlagCoverage Δ
unittest-go-macos-latest54.19% <ø> (+0.14%)⬆️
unittest-go-postgres-65.61% <ø> (+0.19%)⬆️
unittest-go-ubuntu-latest56.60% <ø> (+0.15%)⬆️
unittest-go-windows-2022?
unittest-js74.19% <ø> (-0.05%)⬇️
Impacted FilesCoverage Δ
cli/configssh.go62.58% <0.00%> (-6.48%)⬇️
pty/ptytest/ptytest.go86.95% <0.00%> (-4.35%)⬇️
cli/templateinit.go58.62% <0.00%> (-3.45%)⬇️
coderd/workspaceagents.go55.34% <0.00%> (-2.56%)⬇️
agent/agent.go64.66% <0.00%> (-2.48%)⬇️
provisionerd/provisionerd.go76.03% <0.00%> (-1.61%)⬇️
coderd/organizations.go56.23% <0.00%> (-1.01%)⬇️
coderd/provisionerdaemons.go63.31% <0.00%> (-0.17%)⬇️
coderd/database/queries.sql.go77.78% <0.00%> (-0.13%)⬇️
cli/templates.go100.00% <0.00%> (ø)
... and31 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef581724...0df2fe6. Read thecomment docs.

Comment on lines +26 to +28
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, we need a PAT here. Will probably need help from an org admin to get this

from:https://carlosbecker.com/posts/multi-platform-docker-images-goreleaser-gh-actions/

We need to login into the GitHub Container Registry with a Personal Access Token (PAT), since the default GITHUB_TOKEN does not have enough permissions

@bpmctbpmct marked this pull request as ready for reviewMay 11, 2022 16:50
@bpmct
Copy link
MemberAuthor

This PR is ready for review, but I need help:

  1. generating an access token to replaceGITHUB_TOKEN with additional scope for pushing to GHCR
  2. testing this before an actual release. Should I just useworkflow_dispatch?

@bpmctbpmct requested a review fromcoadlerMay 11, 2022 16:51
@bpmctbpmct changed the titlefeat: build Docker imagesfeat: build & release cross-platform Docker imagesMay 11, 2022
@bpmctbpmct requested a review fromkylecarbsMay 11, 2022 18:56
@bpmctbpmct requested a review fromkylecarbsMay 12, 2022 15:43
@bpmctbpmctenabled auto-merge (squash)May 12, 2022 17:48
@bpmctbpmct merged commitbbb8f83 intomainMay 12, 2022
@bpmctbpmct deleted the bpmct/dockerfile branchMay 12, 2022 17:59
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* feat: add dockerfile and docker-compose* build docker images on release* add Docker dependencies to release.yaml* remove docker compose for now* fix license mismatch* add docker-compose* rename volume* add WF dispatch for debugging
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri left review comments

@kylecarbskylecarbskylecarbs approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@bpmctbpmct

Labels
apiArea: HTTP API
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Feat: build Docker images & document docker-compose
5 participants
@bpmct@mafredri@kylecarbs@misskniss@tjcran
[8]ページ先頭
©2009-2025 Movatter.jp