- Notifications
You must be signed in to change notification settings - Fork1k
feat: use appearance.Fetcher in agentapi#11770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+120 −109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 23, 2024
This was referencedJan 23, 2024
ContributorAuthor
spikecurtis commentedJan 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
This was referencedJan 23, 2024
d63b387
to5ad6f3f
Comparecd743f7
toae35953
Compare
Imagine if it were one PR! It's somewhat inflated tho, since it includes all kinds of stuff that was already merged as long as there is anything unmerged in the stack. |
4fc8623
tocdec5e1
Compareae35953
tocfe6dcc
Comparecdec5e1
to79bee1c
Comparecfe6dcc
to6f243f6
Compare79bee1c
to529250f
Compare6f243f6
toa85394d
Compare529250f
to25063cb
Comparea85394d
to1c21905
Compare This was referencedJan 26, 2024
25063cb
to06d2b3d
Compare1c21905
to98ab55e
Compare06d2b3d
to810bb6e
Compare98ab55e
to174664c
Compare174664c
to385e74a
Compare385e74a
to43a1c9e
Comparedeansheather approved these changesJan 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR updates the Agent API to use the appearance.Fetcher, which is set by entitlement code in Enterprise coderd.
This brings the agentapi into compliance with the Enterprise feature.