Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor Appearance to an interface callable by AGPL code#11769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/10534-appearance-refactor
Jan 29, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJan 23, 2024•
edited
Loading

The new Agent API needs an interface for ServiceBanners, so this PR creates it and refactors the AGPL and Enterprise code to achieve it.

Before we depended on the fact that the HTTP endpoint was missing to serve an empty ServiceBanner on AGPL deployments, but that won't work with dRPC, so we need a real interface to call.

This was referencedJan 23, 2024
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJan 23, 2024•
edited
Loading

@spikecurtisspikecurtis marked this pull request as ready for reviewJanuary 23, 2024 10:24
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch from5c875b2 tof168e58CompareJanuary 23, 2024 18:25
@spikecurtisspikecurtisforce-pushed thespike/10534-appearance-refactor branch fromd63b387 to5ad6f3fCompareJanuary 23, 2024 18:25
Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! You probably already saw the tests but in case not I suppose in some tests we are not settingAppearanceFetcher on the site handler or something like that.

@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch frome980510 toeaabdb7CompareJanuary 25, 2024 11:24
@spikecurtisspikecurtisforce-pushed thespike/10534-appearance-refactor branch fromcdec5e1 to79bee1cCompareJanuary 25, 2024 11:24
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch fromeaabdb7 to6a70ddfCompareJanuary 26, 2024 06:47
@spikecurtisspikecurtisforce-pushed thespike/10534-appearance-refactor branch from79bee1c to529250fCompareJanuary 26, 2024 06:47
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch from6a70ddf toc980d65CompareJanuary 26, 2024 09:24
@spikecurtisspikecurtisforce-pushed thespike/10534-appearance-refactor branch from529250f to25063cbCompareJanuary 26, 2024 09:24
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch fromc980d65 to38f23eaCompareJanuary 26, 2024 15:27
@spikecurtisspikecurtisforce-pushed thespike/10534-appearance-refactor branch from25063cb to06d2b3dCompareJanuary 26, 2024 15:27
Base automatically changed fromspike/10534-service-banners-test tomainJanuary 29, 2024 07:56
@spikecurtisspikecurtisforce-pushed thespike/10534-appearance-refactor branch from06d2b3d to810bb6eCompareJanuary 29, 2024 07:57
@spikecurtisspikecurtis merged commitbc4ae53 intomainJan 29, 2024
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@spikecurtisspikecurtis deleted the spike/10534-appearance-refactor branchJanuary 29, 2024 08:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@code-ashercode-ashercode-asher approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp