Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix TestServiceBanners/Agent#11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 2 commits intomainfromspike/10534-service-banners-test
Jan 29, 2024

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJan 23, 2024•
edited
Loading

The original test is bugged in that it

  1. creates a new AGPL coderd with a new database, so no appearance is set in the DB.
  2. overwrites the agentClient so the assertion after removing the license is against the AGPL coderd

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJan 23, 2024•
edited
Loading

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ahhh that makes sense, I really misunderstood the client setup. Thank you for fixing!

@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch fromffbd488 to05b6c81CompareJanuary 23, 2024 18:25
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch from5c875b2 tof168e58CompareJanuary 23, 2024 18:25
@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch from05b6c81 to7218a92CompareJanuary 24, 2024 10:26
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch fromf168e58 tofaa1f29CompareJanuary 24, 2024 10:26
@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch from7218a92 to7297387CompareJanuary 24, 2024 12:55
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch fromfaa1f29 toe980510CompareJanuary 24, 2024 12:56
@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch from7297387 to280a501CompareJanuary 25, 2024 11:23
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch frome980510 toeaabdb7CompareJanuary 25, 2024 11:24
@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch from280a501 tobfbb557CompareJanuary 26, 2024 06:47
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch fromeaabdb7 to6a70ddfCompareJanuary 26, 2024 06:47
@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch frombfbb557 to5abcdd4CompareJanuary 26, 2024 09:24
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch from6a70ddf toc980d65CompareJanuary 26, 2024 09:24
@spikecurtisspikecurtisforce-pushed thespike/10533-codersdk-derp-map branch from5abcdd4 to0a384f2CompareJanuary 26, 2024 15:27
@spikecurtisspikecurtisforce-pushed thespike/10534-service-banners-test branch fromc980d65 to38f23eaCompareJanuary 26, 2024 15:27
Base automatically changed fromspike/10533-codersdk-derp-map tomainJanuary 29, 2024 07:26
@spikecurtisspikecurtis merged commit37e9479 intomainJan 29, 2024
@spikecurtisspikecurtis deleted the spike/10534-service-banners-test branchJanuary 29, 2024 07:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spikecurtis@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp