- Notifications
You must be signed in to change notification settings - Fork1k
refactor(site): refactor external auth component#11758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code looks good, and big fan of the change!
Uh oh!
There was an error while loading.Please reload this page.
| constnameField=awaitscreen.findByLabelText(nameLabelText); | ||
| // have to use fireEvent b/c userEvent isn't cleaning up properly between tests |
ParkreinerJan 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know that we have the test simplified down now, so this comment wouldn't even be relevant anymore, but do you know if we ever figured out theuserEvent issue? This is the first I've heard of it not cleaning up properly, but some digging made it sounds like it was a bug with the library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know, to be honest, I just removed it from here because we don't need to fill in the name input to see the error.
Related to#11742 |
Recommended improvements:
Before:
Now:
