NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat(scaletest/templates): add support for concurrent scenarios#11753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 18 commits intomainfrommafredri/feat-scaletest-add-load-concurrency-and-percentages

Jan 30, 2024

Merged

feat(scaletest/templates): add support for concurrent scenarios#11753

mafredri merged 18 commits intomainfrommafredri/feat-scaletest-add-load-concurrency-and-percentages

Jan 30, 2024

Conversation

Copy link

Member

mafredri commentedJan 22, 2024•
edited
Loading

Fixes#10794

This PR includes some other fixes as well.

feat(scaletest/templates): add support for concurrent scenarios

036aa8d

github-actionsbot assignedmafredri

Jan 22, 2024

mafredri added2 commits

January 22, 2024 17:15

bump resources to the max

17605a7

remove limits entirely

806c73f

Copy link

Member

johnstcn commentedJan 22, 2024•
edited
Loading

It might be also good to suspend theHelmRelease manifests so that Flux doesn't trigger a deployment during scale testing.

You can do this by settingspec.suspend: true in the manifest YAML (or JSON, as you wish), and setting them back tofalse afterwards.

$ kubectl get helmrelease -n coder-big big -o yamlapiVersion: helm.toolkit.fluxcd.io/v2beta2kind: HelmReleasemetadata:  [...]  name: big  namespace: coder-bigspec:  [...]  suspend: true  [...]status:  [...]

Alternatively, you can just use theflux CLI and runflux (suspend|resume) helmrelease <release_name>

mafredri added10 commits

January 23, 2024 16:42

allow more flexibility in cleanup

96100c0

allow staggered start

569cfc1

improve cleanup

d0fbd2c

fix dashboard screengrabs location

3141efe

add more cleanup cases

f58bf41

fix updating of static time

4754f2f

echo

1236b93

add skip create workspaces option

724e1c5

fix start time regen

916c74d

add retry

aeb9c52

mafredri marked this pull request as ready for review

January 29, 2024 17:14

mafredri requested review fromjohnstcn andmtojek

January 29, 2024 17:14

fix undetected error exit code

60df607

mtojek approved these changes

Jan 30, 2024

View reviewed changes

Copy link

Member

mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It was a bit hard for me to go through this review due to Bash syntax, so please assume this to be a high-level review 👍

scaletest/templates/scaletest-runner/main.tfShow resolvedHide resolved

scaletest/templates/scaletest-runner/scripts/run.sh

		# we're creating a lot of workspaces at once and some of them may fail
		# due to network issues or other transient errors.
		coder exp scaletest create-workspaces \
		--retry 5 \

Copy link

Member

mtojekJan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm curious if this must be ignored&retried, maybe we should identify and fix problems in a different way, even provisioning workspaces slower?

Anyway, consider it to be a side thought.

Copy link

MemberAuthor

mafredriJan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We would have to ensure terraform registry is cached locally, once we know workspace builds don't use any external networking, we could potentially disable the retry, if we want. 👍🏻