- Notifications
You must be signed in to change notification settings - Fork913
feat: change codersdk to use tailnet v2 for DERPMap updates#11736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 22, 2024
This was referencedJan 22, 2024
ContributorAuthor
spikecurtis commentedJan 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@spikecurtis and the rest of your teammates on |
This was referencedJan 22, 2024
924c97f to5a7c1aaCompare63bc699 to19a4ef4Comparee61389c toc7097e9Comparedb15895 to081584fComparec7097e9 toe00d517Compare081584f to05d21b1Comparee00d517 toffbd488Compare This was referencedJan 23, 2024
05d21b1 tocc0751dCompareffbd488 to05b6c81Compare05b6c81 to7218a92Compare7218a92 to7297387Compare7297387 to280a501Comparebfbb557 to5abcdd4Compare This was referencedJan 26, 2024
5abcdd4 to0a384f2Comparecoadler approved these changesJan 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
fixes#10533
refactors
codersdkworkspace agent dialer to use a single websocket connection to the tailnet v2 API for both coordination and DERPMap updates, rather than separate websockets (and the v1 API for DERPMaps).