Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add template activity_bump property#11734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 10 commits intomainfromdean/template-activity-bump-dur
Feb 13, 2024

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedJan 22, 2024•
edited
Loading

Adds a new property to templatesactivity_bump which defaults to1h to persist the current behavior. Allows the template admin to specify how much time activity bump events should add to the workspace deadline.

TODO:

  • Dashboard: template create
  • Dashboard: template edit

Supercedes#10866
Closes#11690

stirby reacted with hooray emoji
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This only covers thetemplate side of things. Do we not also have to make it editable fromworkspace?

Just asking, personally I think less toggles is better, and might not be necessary on the workspace.

Comment on lines 71 to 72
-- We only bump if the template has an activity bump duration set.
AND l.activity_bump IS NOT NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can never be null. Should this be= 0 or something?

deansheather reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this didn't trip up tests since this is essentially doing nothing in the query... if it's 0 we're adding 0 to the current deadline anyways lol.

I fixed it anyways since it's better to be safe IMO

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelFeb 1, 2024
@deansheatherdeansheather removed the staleThis issue is like stale bread. labelFeb 8, 2024
@deansheather
Copy link
MemberAuthor

This only covers the template side of things. Do we not also have to make it editable from workspace?

Just asking, personally I think less toggles is better, and might not be necessary on the workspace.

@Emyrk I agree, I think we're going to keep this as a template setting for now.

Copy link
Member

@johnstcnjohnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Backend looks OK. Tested manually by updating deadline to >95% with 5m bump interval.

Some UI issues remain e.g. activity bump shows up as fractional hours
image

@deansheather
Copy link
MemberAuthor

Some UI issues remain e.g. activity bump shows up as fractional hours

Fixed! Apparently most of our validations didn't have.integer() and.required()

@deansheatherdeansheatherenabled auto-merge (squash)February 13, 2024 06:52
@deansheatherdeansheather merged commite1e352d intomainFeb 13, 2024
@deansheatherdeansheather deleted the dean/template-activity-bump-dur branchFebruary 13, 2024 07:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add inactivity timeout separate from initial TTL
3 participants
@deansheather@johnstcn@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp