- Notifications
You must be signed in to change notification settings - Fork927
feat: add endpoints to oauth2 provider apps response#11718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8d51623 to1502265Compare7c994d0 to9ef2971CompareThese will show up when configuring the application along with theclient ID and everything else. Should make it easier to configure theapplication, otherwise you will have to go look up the URLs in thedocs (which are not yet written).Co-authored-by: Steven Masley <stevenmasley@gmail.com>
9ef2971 to277269fCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Checked the stories, and the client-side stuff looks good! If there aren't any issues with the Go code, the PR should be good to approve
| }} | ||
| /> | ||
| </CopyableValue> | ||
| <dl css={styles.dataList}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Big fan of the definition list usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you screencap what this looks like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The Go looks fine though 👍
It can be viewed and messed around with here on Chromatic:https://624de63c6aacee003aa84340-yiqrjtuxwr.chromatic.com/?path=/story/pages-deploysettingspage-editoauth2apppageview--default |
Uh oh!
There was an error while loading.Please reload this page.
These will show up when configuring the application along with the client ID and everything else. Should make it easier to use the application, otherwise you will have to go look up the URLs in the docs (which are not yet written).
Mostly extracted from#11609 to make that PR smaller, except I added a list to display them in the frontend as well.