- Notifications
You must be signed in to change notification settings - Fork927
chore: pass lifetime directly into api key generate#11715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fd94e7b to5596f95CompareRather than passing all the deployment values. This is to make iteasier to generate API keys as part of the oauth flow.I also added and fixed a test for when the lifetime is set and thedefault and expiration are unset.Co-authored-by: Steven Masley <stevenmasley@gmail.com>
5596f95 to0b0b03fCompare20 tasks
This is fine to unblock, we should do this long term:#11693 |
Emyrk approved these changesJan 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This was pulled out of#11609. I am trying to split up that PR so we can review and merge more easily.
Rather than passing all the deployment values, pass just the lifetime since that is all we use. This is to make it easier to generate API keys as part of the oauth flow (otherwise we will need send the deployment values into the identity provider).
I also added and fixed a test for when the lifetime is set and the default and expiration are unset (was just missing a multiplication by
time.Secondto use seconds instead of nanoseconds or whatever the default is).