- Notifications
You must be signed in to change notification settings - Fork1k
feat: add "updated" search param to workspaces#11714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure I understand why the parameter is named differently at all parts of the stack. The frontend is namedoutdated
-- which makes the most sense to me for the name. But the backend name isupdated
and then the database parameter isupdate_active
. Why not have them consistent?
There is only two names from a code POV. I am using For the api I used the word "Outdated" is just the helper text for the quick search query list. I felt this would be more commonly used that searching for all updated workspaces. And the ticket was requesting this as the feature. So that is the one I made as the quick link. If you click it though, the language is "updated". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Personally I thinkoutdated
makes more sense as the query param but ultimately up to you.
I will use |
ac2be0e
toae0179f
Compare
fixes#11325
Can now search for updated workspaces in the search query