Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add "updated" search param to workspaces#11714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 7 commits intomainfromstevenmasley/active_template_filter
Jan 23, 2024

Conversation

Emyrk
Copy link
Member

fixes#11325

Can now search for updated workspaces in the search query

Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure I understand why the parameter is named differently at all parts of the stack. The frontend is namedoutdated -- which makes the most sense to me for the name. But the backend name isupdated and then the database parameter isupdate_active. Why not have them consistent?

@Emyrk
Copy link
MemberAuthor

I'm not sure I understand why the parameter is named differently at all parts of the stack. The frontend is namedoutdated -- which makes the most sense to me for the name. But the backend name isupdated and then the database parameter isupdate_active. Why not have them consistent?

There is only two names from a code POV.

I am usingUsingActive on the database because that is physically the database column we are checking. It felt odd to put "updated" there because that word doesn't feel semantically correct.

For the api I used the wordupdated since that is the phrasing of the original ticket. And we use the language "Update" on the workspaces page when a workspace is out-of-date. So the FE tends to useupdated as the language.

"Outdated" is just the helper text for the quick search query list. I felt this would be more commonly used that searching for all updated workspaces. And the ticket was requesting this as the feature. So that is the one I made as the quick link.

Screenshot from 2024-01-22 14-45-29

If you click it though, the language is "updated".

Screenshot from 2024-01-22 14-46-31

@EmyrkEmyrk requested a review fromsreyaJanuary 22, 2024 20:47
Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Personally I thinkoutdated makes more sense as the query param but ultimately up to you.

@Emyrk
Copy link
MemberAuthor

Personally I thinkoutdated makes more sense as the query param but ultimately up to you.

I will useoutdated as the query param 👍

@EmyrkEmyrkforce-pushed thestevenmasley/active_template_filter branch fromac2be0e toae0179fCompareJanuary 23, 2024 16:33
@EmyrkEmyrk merged commitd6ba0df intomainJan 23, 2024
@EmyrkEmyrk deleted the stevenmasley/active_template_filter branchJanuary 23, 2024 17:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@sreyasreyasreya approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Show workspaces using out-of-date template versions

2 participants

@Emyrk@sreya

[8]ページ先頭

©2009-2025 Movatter.jp