Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add GIT_COMMITTER information to agent env vars#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromgitinfo
Apr 26, 2022

Conversation

kylecarbs
Copy link
Member

This makes setting up git a bit simpler, and users
can always override these values!

We'll probably add a way to disable our Git integration
anyways, so these could be part of that.

@kylecarbskylecarbs requested a review fromcoadlerApril 25, 2022 22:45
@kylecarbskylecarbs self-assigned thisApr 25, 2022
@codecov
Copy link

codecovbot commentedApr 25, 2022
edited
Loading

Codecov Report

Merging#1171 (9d76d9d) intomain (947e8f9) willdecrease coverage by0.31%.
The diff coverage is54.54%.

@@            Coverage Diff             @@##             main    #1171      +/-   ##==========================================- Coverage   66.51%   66.20%   -0.32%==========================================  Files         263      263                Lines       16573    16613      +40       Branches      156      156              ==========================================- Hits        11024    10998      -26- Misses       4419     4470      +51- Partials     1130     1145      +15
FlagCoverage Δ
unittest-go-macos-latest53.62% <54.54%> (-0.15%)⬇️
unittest-go-postgres-65.53% <54.54%> (-0.27%)⬇️
unittest-go-ubuntu-latest56.12% <54.54%> (-0.19%)⬇️
unittest-go-windows-202253.20% <54.54%> (-0.10%)⬇️
unittest-js67.45% <ø> (ø)
Impacted FilesCoverage Δ
codersdk/workspaceagents.go51.11% <37.50%> (-2.25%)⬇️
coderd/workspaceagents.go58.14% <53.44%> (-5.07%)⬇️
agent/agent.go66.90% <76.92%> (-1.60%)⬇️
coderd/coderd.go97.52% <100.00%> (ø)
cli/cliui/agent.go77.19% <0.00%> (-5.27%)⬇️
peerbroker/listen.go84.03% <0.00%> (-3.37%)⬇️
coderd/turnconn/turnconn.go81.91% <0.00%> (-3.20%)⬇️
... and3 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update947e8f9...9d76d9d. Read thecomment docs.

This makes setting up git a bit simpler, and userscan always override these values!We'll probably add a way to disable our Git integrationanyways, so these could be part of that.
@kylecarbskylecarbs merged commit744a00a intomainApr 26, 2022
@kylecarbskylecarbs deleted the gitinfo branchApril 26, 2022 01:03
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This makes setting up git a bit simpler, and userscan always override these values!We'll probably add a way to disable our Git integrationanyways, so these could be part of that.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@coadler

[8]ページ先頭

©2009-2025 Movatter.jp