NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

fix: cancel button on create-workspace page wasn't redirecting correctly#117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bryphe-coder merged 1 commit intomainfrombryphe/fix/projects-cancel-redirect

Feb 1, 2022

Merged

fix: cancel button on create-workspace page wasn't redirecting correctly#117

bryphe-coder merged 1 commit intomainfrombryphe/fix/projects-cancel-redirect

Feb 1, 2022

Conversation

Copy link

Contributor

bryphe-coder commentedFeb 1, 2022

Issue:

Pressingcancel on the create-workspace page would give an unexpected result:

Defect:

Originally, theproject variable was being used for the project name - but then got refactored to keep the actualproject data. However, thecancel button logic wasn't updated to take this into account - pushing an incorrect URL.

Fix:

Use theprojectName variable, which we already extract for the router

fix: cancel button on create-workspace page wasn't going to the right…

02998f1

… place

bryphe-coder self-assigned this

Feb 1, 2022

bryphe-coder requested a review fromkylecarbs

February 1, 2022 01:44

Copy link

codecovbot commentedFeb 1, 2022•
edited
Loading

Codecov Report

Merging#117 (02998f1) intomain (515e55d) willincrease coverage by2.73%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main     #117      +/-   ##==========================================+ Coverage   68.90%   71.63%   +2.73%==========================================  Files          86       91       +5       Lines        3447     3670     +223       Branches       59       59              ==========================================+ Hits         2375     2629     +254+ Misses        884      823      -61- Partials      188      218      +30

Flag	Coverage Δ
unittest-go-macos-latest	`67.96% <ø> (+0.17%)`	⬆️
unittest-go-ubuntu-latest	`69.77% <ø> (?)`
unittest-go-windows-latest	`67.44% <ø> (?)`
unittest-js	`74.72% <0.00%> (ø)`

Impacted Files	Coverage Δ
...pages/projects/[organization]/[project]/create.tsx	`0.00% <0.00%> (ø)`
provisioner/terraform/parse.go	`75.00% <0.00%> (ø)`
provisioner/terraform/serve.go	`66.66% <0.00%> (ø)`
coderd/userpassword/userpassword.go	`63.41% <0.00%> (ø)`
database/postgres/postgres.go	`70.00% <0.00%> (ø)`
provisioner/terraform/provision.go	`57.62% <0.00%> (ø)`
peer/channel.go	`84.75% <0.00%> (+0.60%)`	⬆️
peer/conn.go	`77.86% <0.00%> (+2.08%)`	⬆️
coderd/coderdtest/coderdtest.go	`100.00% <0.00%> (+22.64%)`	⬆️
database/migrate.go	`52.38% <0.00%> (+52.38%)`	⬆️
... and1 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update515e55d...02998f1. Read thecomment docs.