NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

feat: expose support links as env variables#11697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mtojek merged 4 commits intomainfrom11628-fix-1

Jan 19, 2024

Merged

feat: expose support links as env variables#11697

mtojek merged 4 commits intomainfrom11628-fix-1

Jan 19, 2024

Conversation

Copy link

Member

mtojek commentedJan 19, 2024

Fixes:#11628

This PR is a workaround to enable support links to be passed as env variables. This is an alternative solution to the proposed concept with enumerated vars (..._0_NAME,..._1_NAME), which might be tricky to implement - discover the number of vars, guess the config schema, etc. JSON object seems to be more flexible format for such cases.

export CODER_SUPPORT_LINKS='[{"name": "Hello GitHub", "target": "https://github.com/coder/coder", "icon": "bug"}, {"name": "Hello Slack", "target": "https://codercom.slack.com/archives/C014JH42DBJ", "icon": "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/slack.svg"}, {"name": "Hello Discord", "target": "https://discord.gg/coder", "icon": "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/discord.svg"}, {"name": "Hello Foobar", "target": "https://discord.gg/coder", "icon": "/emojis/1f3e1.png"}]'

export CODER_SUPPORT_LINKS=$(cat<<EOF[{"name": "Hello GitHub", "target": "https://github.com/coder/coder", "icon": "bug"}, {"name": "Hello Slack", "target": "https://codercom.slack.com/archives/C014JH42DBJ", "icon": "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/slack.svg"}, {"name": "Hello Discord", "target": "https://discord.gg/coder", "icon": "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/discord.svg"}, {"name": "Hello Foobar", "target": "https://discord.gg/coder", "icon": "/emojis/1f3e1.png"}]EOF)

or indeployment.yaml

env:        -name:CODER_SUPPORT_LINKSvalue:>            [{"name": "Hello GitHub", "target": "https://github.com/coder/coder", "icon": "bug"},             {"name": "Hello Slack", "target": "https://codercom.slack.com/archives/C014JH42DBJ", "icon": "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/slack.svg"},             {"name": "Hello Discord", "target": "https://discord.gg/coder", "icon": "https://raw.githubusercontent.com/coder/coder/main/site/static/icon/discord.svg"},             {"name": "Hello Foobar", "target": "https://discord.gg/coder", "icon": "/emojis/1f3e1.png"}]

feat: expose support links as env variables

bd34973

mtojek self-assigned this

Jan 19, 2024

mtojek added3 commits

January 19, 2024 09:56

golden

bb10410

table

ec30d1e

fix test

450a7e6

mtojek marked this pull request as ready for review

January 19, 2024 09:33

mtojek requested review frommatifali andericpaulsen

January 19, 2024 09:33

matifali approved these changes

Jan 19, 2024

View reviewed changes

Copy link

Member

matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great. I think it's a good enough workaround. What do you tink@ammario?

Copy link

MemberAuthor

mtojek commentedJan 19, 2024

I don't mind supporting both options. There could be users who prefer JSON over enumerated format (_0_NAME,_1_NAME,...). I will merge this change, and we can iterate on the other option later.