Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: check agent API version on connection#11696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/10531-check-agent-api-version
Jan 23, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedJan 19, 2024•
edited
Loading

fixes#10531

Adds a check forversion on connection to the Agent API websocket endpoint. This is primarily for future-proofing, so that up-level agents get a sensible error if they connect to a back-level Coderd.

It also refactors the location of theCurrentVersion variables, to be part of theproto packages, since the versions refer to the APIs defined therein.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedJan 19, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewJanuary 19, 2024 08:24
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch fromc7f73d4 to135bd48CompareJanuary 19, 2024 12:36
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch from3469608 tof56be8eCompareJanuary 19, 2024 12:36
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from135bd48 toecef2a9CompareJanuary 22, 2024 06:58
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch fromf56be8e to24a943cCompareJanuary 22, 2024 06:59
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch fromecef2a9 to0b0b1a4CompareJanuary 22, 2024 08:05
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch from24a943c to16322d1CompareJanuary 22, 2024 08:05
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from0b0b1a4 to7a301f1CompareJanuary 22, 2024 11:18
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch from16322d1 toc91b1c0CompareJanuary 22, 2024 11:18
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from7a301f1 to0e38400CompareJanuary 22, 2024 11:30
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch fromc91b1c0 to671a2e9CompareJanuary 22, 2024 11:30
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from0e38400 to35d99a8CompareJanuary 22, 2024 12:47
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch from671a2e9 to5fa6879CompareJanuary 22, 2024 12:47
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from35d99a8 to66da7c6CompareJanuary 22, 2024 12:48
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch from5fa6879 to8ad2024CompareJanuary 22, 2024 12:48
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from66da7c6 to62e95deCompareJanuary 23, 2024 05:52
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch from8ad2024 tod7a1794CompareJanuary 23, 2024 05:52
@spikecurtisspikecurtisforce-pushed thespike/10533-servertailnet-set-lost branch from62e95de to5695841CompareJanuary 23, 2024 09:09
@spikecurtisspikecurtisforce-pushed thespike/10531-check-agent-api-version branch fromd7a1794 to59e8c2fCompareJanuary 23, 2024 09:09
Base automatically changed fromspike/10533-servertailnet-set-lost tomainJanuary 23, 2024 09:17
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Agent API v2 websocket endpoint
2 participants
@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp